ocioview updates & fixes#1966
Merged
KelSolaar merged 7 commits intoMay 6, 2024
Merged
Conversation
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
KelSolaar
reviewed
May 5, 2024
| # OCIO processor | ||
| elif isinstance(msg_raw, ocio.Processor): | ||
| self._prev_cpu_proc = msg_raw | ||
| elif ( |
Contributor
There was a problem hiding this comment.
Feels a bit "magical" :)
Might need a dedicated definition in the future to manage all those comparisons if we need to do it elsewhere.
Contributor
There was a problem hiding this comment.
I was talking about this block specifically:
isinstance(msg_raw, tuple)
and len(msg_raw) == 2
and isinstance(msg_raw[0], ProcessorContext)
and isinstance(msg_raw[1], ocio.Processor)
KelSolaar
approved these changes
May 5, 2024
Contributor
KelSolaar
left a comment
There was a problem hiding this comment.
Thanks @michdolan, LGTM!
doug-walker
approved these changes
May 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a number of updates and improvements to
ocioview:ProcessorContextinterface to reference input and output processor parameters so application components that receive a viewer's processor can inspect the config items that created it. This dataclass includes the processor's: input color space name, output transform item type, output transform item name, and transform direction. This should resolve questions raised in PR: ocioview - Chromaticities Inspector #1914 .